[webkit-changes] [WebKit/WebKit] c4f56f: [Filters] Generate serializers for Filter and Filt...

Sat Feb 4 17:33:41 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4f56fe6d1f91bf604feeb3af5eab48173e34af6
      https://github.com/WebKit/WebKit/commit/c4f56fe6d1f91bf604feeb3af5eab48173e34af6
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/graphics/filters/FEBlend.h
    M Source/WebCore/platform/graphics/filters/FEColorMatrix.h
    M Source/WebCore/platform/graphics/filters/FEComponentTransfer.h
    M Source/WebCore/platform/graphics/filters/FEComposite.h
    M Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h
    M Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp
    M Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h
    M Source/WebCore/platform/graphics/filters/FEDisplacementMap.h
    M Source/WebCore/platform/graphics/filters/FEDropShadow.h
    M Source/WebCore/platform/graphics/filters/FEFlood.h
    M Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
    M Source/WebCore/platform/graphics/filters/FEImage.h
    M Source/WebCore/platform/graphics/filters/FELighting.h
    M Source/WebCore/platform/graphics/filters/FEMerge.h
    M Source/WebCore/platform/graphics/filters/FEMorphology.h
    M Source/WebCore/platform/graphics/filters/FEOffset.h
    M Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp
    M Source/WebCore/platform/graphics/filters/FESpecularLighting.h
    M Source/WebCore/platform/graphics/filters/FETile.h
    M Source/WebCore/platform/graphics/filters/FETurbulence.h
    M Source/WebCore/platform/graphics/filters/Filter.h
    M Source/WebCore/platform/graphics/filters/PointLightSource.h
    M Source/WebCore/platform/graphics/filters/SpotLightSource.h
    M Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp
    M Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp
    M Source/WebCore/svg/SVGFESpecularLightingElement.cpp
    M Source/WebCore/svg/graphics/filters/SVGFilterExpression.h
    A Source/WebCore/svg/graphics/filters/SVGFilterExpressionReference.h
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h
    M Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h
    M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in
    R Source/WebKit/Platform/IPC/FilterReference.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Shared/WebCoreArgumentCoders.cpp
    M Source/WebKit/Shared/WebCoreArgumentCoders.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

  Log Message:
  -----------
  [Filters] Generate serializers for Filter and FilterEffects
https://bugs.webkit.org/show_bug.cgi?id=250220
rdar://103960558

Reviewed by Alex Christensen.

Also remove FilterReference and replace it with Ref<Filter> and move the superclass
coders to WebCoreArgumentCoders.

* Source/WebCore/Headers.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/filters/DistantLightSource.h:
(WebCore::DistantLightSource::encode const): Deleted.
(WebCore::DistantLightSource::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEBlend.h:
(WebCore::FEBlend::encode const): Deleted.
(WebCore::FEBlend::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEColorMatrix.h:
(WebCore::FEColorMatrix::encode const): Deleted.
(WebCore::FEColorMatrix::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEComponentTransfer.h:
(WebCore::ComponentTransferFunction::encode const): Deleted.
(WebCore::ComponentTransferFunction::decode): Deleted.
(WebCore::FEComponentTransfer::encode const): Deleted.
(WebCore::FEComponentTransfer::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEComposite.h:
(WebCore::FEComposite::encode const): Deleted.
(WebCore::FEComposite::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h:
(WebCore::FEConvolveMatrix::encode const): Deleted.
(WebCore::FEConvolveMatrix::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp:
* Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h:
(WebCore::FEDiffuseLighting::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEDisplacementMap.h:
(WebCore::FEDisplacementMap::encode const): Deleted.
(WebCore::FEDisplacementMap::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEDropShadow.h:
(WebCore::FEDropShadow::encode const): Deleted.
(WebCore::FEDropShadow::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEFlood.h:
(WebCore::FEFlood::encode const): Deleted.
(WebCore::FEFlood::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:
(WebCore::FEGaussianBlur::encode const): Deleted.
(WebCore::FEGaussianBlur::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEImage.h:
(WebCore::FEImage::encode const): Deleted.
(WebCore::FEImage::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FELighting.h:
(WebCore::FELighting::lightSource const):
(WebCore::FELighting::encode const): Deleted.
(WebCore::FELighting::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEMerge.h:
(WebCore::FEMerge::encode const): Deleted.
(WebCore::FEMerge::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEMorphology.h:
(WebCore::FEMorphology::encode const): Deleted.
(WebCore::FEMorphology::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FEOffset.h:
(WebCore::FEOffset::encode const): Deleted.
(WebCore::FEOffset::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp:
* Source/WebCore/platform/graphics/filters/FESpecularLighting.h:
(WebCore::FESpecularLighting::decode): Deleted.
* Source/WebCore/platform/graphics/filters/FETurbulence.h:
(WebCore::FETurbulence::encode const): Deleted.
(WebCore::FETurbulence::decode): Deleted.
* Source/WebCore/platform/graphics/filters/Filter.h:
(isType):
* Source/WebCore/platform/graphics/filters/PointLightSource.h:
(WebCore::PointLightSource::encode const): Deleted.
(WebCore::PointLightSource::decode): Deleted.
* Source/WebCore/platform/graphics/filters/SpotLightSource.h:
(WebCore::SpotLightSource::encode const): Deleted.
(WebCore::SpotLightSource::decode): Deleted.
* Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
(WebCore::FELightingSoftwareApplier::apply const):
* Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
* Source/WebCore/svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
* Source/WebCore/svg/graphics/filters/SVGFilterExpression.h:
* Source/WebCore/svg/graphics/filters/SVGFilterExpressionReference.h: Copied from Source/WebCore/svg/graphics/filters/SVGFilterExpression.h.
(WebCore::SVGFilterExpressionNode::encode const):
(WebCore::SVGFilterExpressionNode::decode):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::drawFilteredImageBuffer):
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
* Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getFilteredImageForImageBuffer):
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
* Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Source/WebKit/Platform/IPC/FilterReference.h: Removed.
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
* Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<LightSource>::encode):
(IPC::ArgumentCoder<LightSource>::decode):
(IPC::ArgumentCoder<FilterFunction>::encode):
(IPC::ArgumentCoder<FilterFunction>::decode):
(IPC::ArgumentCoder<FilterEffect>::encode):
(IPC::ArgumentCoder<FilterEffect>::decode):
(IPC::ArgumentCoder<CSSFilter>::encode):
(IPC::ArgumentCoder<CSSFilter>::decode):
(IPC::ArgumentCoder<SVGFilter>::encode):
(IPC::ArgumentCoder<SVGFilter>::decode):
(IPC::ArgumentCoder<Filter>::encode):
(IPC::ArgumentCoder<Filter>::decode):
* Source/WebKit/Shared/WebCoreArgumentCoders.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordDrawFilteredImageBuffer):
* Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::getFilteredImage):

Canonical link: https://commits.webkit.org/259862@main