[webkit-changes] [WebKit/WebKit] 53ce8c: Ensure WebFullScreenManager is removed as EventLis...

Jean-Yves Avenard noreply at github.com
Sat Feb 4 04:41:58 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53ce8c35db4324b63de6d0a600298eb99387395d
      https://github.com/WebKit/WebKit/commit/53ce8c35db4324b63de6d0a600298eb99387395d
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-02-04 (Sat, 04 Feb 2023)

  Changed paths:
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Ensure WebFullScreenManager is removed as EventListener when page closes
https://bugs.webkit.org/show_bug.cgi?id=251566
rdar://103823114

Reviewed by Youenn Fablet.

When the page close, break the cycles with WebFullScreenManager and ensure
WebFullScreenManager is no longer registered as event listener.

* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::~WebFullScreenManager):
(WebKit::WebFullScreenManager::invalidate):
(WebKit::WebFullScreenManager::element):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):

Canonical link: https://commits.webkit.org/259855@main




More information about the webkit-changes mailing list