[webkit-changes] [WebKit/WebKit] 1b3346: [run-webkit-tests] Handle diverse WatchOS device t...

Jonathan Bedard noreply at github.com
Fri Feb 3 17:14:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b334608e22428bfcb4db180417c93e50c06333f
      https://github.com/WebKit/WebKit/commit/1b334608e22428bfcb4db180417c93e50c06333f
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/xcode/device_type.py
    M Tools/Scripts/webkitpy/xcode/device_type_unittest.py
    M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  -----------
  [run-webkit-tests] Handle diverse WatchOS device types
https://bugs.webkit.org/show_bug.cgi?id=251723
rdar://105021853

Reviewed by Ryan Haddad.

* Tools/Scripts/webkitpy/xcode/device_type.py:
(DeviceType.standardize_hardware_type): Refactor to allow invocation without a class instance,
add a check for WatchOS variants.
(DeviceType.standardized_hardware_type): Invoke refactored function
* Tools/Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest.test_watch_standardization):
* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager._get_device_identifier_for_type): Invoke DeviceType.standardize_hardware_type
instead of re-implimenting the function.

Canonical link: https://commits.webkit.org/259848@main




More information about the webkit-changes mailing list