[webkit-changes] [WebKit/WebKit] c07695: Web Inspector: `inspectable` API doesn't have a co...
Patrick Angle
noreply at github.com
Fri Feb 3 14:40:14 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c0769577c02dff910bc63e154e78be226bcf43cc
https://github.com/WebKit/WebKit/commit/c0769577c02dff910bc63e154e78be226bcf43cc
Author: Patrick Angle <pangle at apple.com>
Date: 2023-02-03 (Fri, 03 Feb 2023)
Changed paths:
M Source/JavaScriptCore/API/JSContext.h
M Source/JavaScriptCore/API/JSContext.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Log Message:
-----------
Web Inspector: `inspectable` API doesn't have a correct Objective-C getter
https://bugs.webkit.org/show_bug.cgi?id=251702
rdar://105012093
Reviewed by Tim Horton.
Boolean getters should have an `is` prefix. Currently `inspectable` is not adhering to this rule. The current getter
also doesn't match the approved API design. This API has not yet shipped, and there is no internal usage of
`[webView inspectable]`, so this change will not break existing clients. `webView.inspectable` remains correct and
unchanged.
* Source/JavaScriptCore/API/JSContext.h:
* Source/JavaScriptCore/API/JSContext.mm:
(-[JSContext isInspectable]):
(-[JSContext inspectable]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView isInspectable]):
(-[WKWebView inspectable]): Deleted.
Canonical link: https://commits.webkit.org/259840@main
More information about the webkit-changes
mailing list