[webkit-changes] [WebKit/WebKit] f83957: Change sensitivity level of webpushd diagnostic lo...

bnham noreply at github.com
Fri Feb 3 11:10:04 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f83957784da956a05e3c07152a430180fd0d456f
      https://github.com/WebKit/WebKit/commit/f83957784da956a05e3c07152a430180fd0d456f
  Author: Ben Nham <nham at apple.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/Assertions.h
    M Source/WebCore/workers/service/server/SWServer.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp

  Log Message:
  -----------
  Change sensitivity level of webpushd diagnostic logs (take 2)
https://bugs.webkit.org/show_bug.cgi?id=251631
rdar://104977357

Reviewed by Brady Eidson.

Fix some additional places where we log the scope of a push subscription with a private instead of
sensitive log level. We already did some of this in 259764 at main but missed a few callsites that used
a different log level macro.

* Source/WTF/wtf/Assertions.h:
* Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::processPushMessage):
(WebCore::SWServer::processNotificationEvent):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processPushMessage):
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _processPushMessage:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClose:completionHandler:]):
* Source/WebKit/UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):

Canonical link: https://commits.webkit.org/259827@main




More information about the webkit-changes mailing list