[webkit-changes] [WebKit/WebKit] 3aad91: [GStreamer] Fix a failure of fast/speechsynthesis/...

ChangSeok Oh noreply at github.com
Fri Feb 3 10:15:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3aad9165b15df302e611f79f33378137101d390f
      https://github.com/WebKit/WebKit/commit/3aad9165b15df302e611f79f33378137101d390f
  Author: ChangSeok Oh <changseok at webkit.org>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M LayoutTests/fast/speechsynthesis/voices-non-mock-expected.txt
    M LayoutTests/fast/speechsynthesis/voices-non-mock.html
    M LayoutTests/platform/glib/TestExpectations
    A LayoutTests/platform/glib/fast/speechsynthesis/voices-non-mock-expected.txt
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl

  Log Message:
  -----------
  [GStreamer] Fix a failure of fast/speechsynthesis/voices-non-mock.html
https://bugs.webkit.org/show_bug.cgi?id=250656

Reviewed by Philippe Normand.

The voices-non-mock.html used a mac platform-specific value to test the number
of available voices. This change introduces a new method of Internals, which allows
each port to decide its minimum expected voice count. Besides, this change includes
a new expected result for ports using GStreamer since the number of available voices
for those ports differs from that of the mac port.

* LayoutTests/fast/speechsynthesis/voices-non-mock.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/fast/speechsynthesis/voices-non-mock-expected.txt: Added.
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::minimumExpectedVoiceCount):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/259820@main




More information about the webkit-changes mailing list