[webkit-changes] [WebKit/WebKit] a19262: Fix bug in CSSCalcOperationNode::createHypot() fou...
Chris Dumez
noreply at github.com
Fri Feb 3 07:29:05 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a19262e5a43e349a37ccd6de7222d87fa78ffb18
https://github.com/WebKit/WebKit/commit/a19262e5a43e349a37ccd6de7222d87fa78ffb18
Author: Chris Dumez <cdumez at apple.com>
Date: 2023-02-03 (Fri, 03 Feb 2023)
Changed paths:
M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
Log Message:
-----------
Fix bug in CSSCalcOperationNode::createHypot() found by new libcpp assertions
https://bugs.webkit.org/show_bug.cgi?id=251655
rdar://104981701
Reviewed by Ryosuke Niwa.
fast/css/calc-parsing.html has been crashing on Internal bots since we enabled
the new libcpp assertions. This was caused by CSSCalcOperationNode::createHypot()
not checking if expectedCategory was std::nullopt before dereferencing it.
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::createHypot):
Canonical link: https://commits.webkit.org/259814@main
More information about the webkit-changes
mailing list