[webkit-changes] [WebKit/WebKit] a2b572: [web-animations] keyframes should be recomputed wh...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2b572c83047686080be7e4d7af8c413ebf917fa
      https://github.com/WebKit/WebKit/commit/a2b572c83047686080be7e4d7af8c413ebf917fa
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/css/CSSCustomPropertyValue.h
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleResolver.h

  Log Message:
  -----------
  [web-animations] keyframes should be recomputed when a parent element changes value for a custom property set to "inherit"
https://bugs.webkit.org/show_bug.cgi?id=251596

Reviewed by Antti Koivisto.

We keep a set of CSS properties set to "inherit" in a KeyframeEffect but until now only considered
"standard" CSS properties. We now also consider custom properties by changing the set's type from
HashSet<CSSPropertyID> to HashSet<AnimatableProperty>.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::inheritedProperties const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/259812@main