[webkit-changes] [WebKit/WebKit] 663a50: storage/indexeddb/modern/leak-1.html is a flaky fa...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 663a5020f5eb48eb77f8c7c7315038233cd0d13e
      https://github.com/WebKit/WebKit/commit/663a5020f5eb48eb77f8c7c7315038233cd0d13e
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M LayoutTests/storage/indexeddb/modern/leak-1-expected.txt
    M LayoutTests/storage/indexeddb/modern/resources/leak-1.js

  Log Message:
  -----------
  storage/indexeddb/modern/leak-1.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=251487
rdar://104651623

Reviewed by Youenn Fablet.

This test is used to verify IndexedDB objects can be garbage collected at expected cases, so as long as it can pass once,
it mean our implementation is expected. Therefore, the flakiness is a test issue. To make this test more robust, this
patch makes following changes:
1. Invoke gc() multiple times, with 100ms wait between each call to increase the chance that objects are collected.
2. Avoid using IndexedDB functions via helper script, to avoid unexpcted reference.
3. Use `let` to declare variables if possible, so we don't need to unset them.

* LayoutTests/storage/indexeddb/modern/leak-1-expected.txt:
* LayoutTests/storage/indexeddb/modern/resources/leak-1.js:
(prepareDatabase):
(testSucceeded):
(sleep):
(async test):
(log): Deleted.
(next): Deleted.
(asyncNext): Deleted.
(prepareDatabase.event.target.onsuccess): Deleted.
(testSteps): Deleted.

Canonical link: https://commits.webkit.org/259804@main