[webkit-changes] [WebKit/WebKit] 459951: Fix DUMP_NODE_STATISTICS

Cameron McCormack noreply at github.com
Thu Feb 2 20:22:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4599514bba5957e7ea46aef8646a102dcdd6208e
      https://github.com/WebKit/WebKit/commit/4599514bba5957e7ea46aef8646a102dcdd6208e
  Author: Cameron McCormack <heycam at apple.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/ElementRareData.h
    M Source/WebCore/dom/Node.cpp
    M Source/WebCore/dom/NodeRareData.h

  Log Message:
  -----------
  Fix DUMP_NODE_STATISTICS
https://bugs.webkit.org/show_bug.cgi?id=251646
<rdar://problem/104981983>

Reviewed by Ryosuke Niwa.

- Add a missing UseType
- Reorder UseTypes to match field order
- Fix rareDataSingleUseTypeCounts key type to be big enough
- Disable assertion in ContainerNode::removeAllChildrenWithScriptAssertion, which is not valid when all nodes created get a weak pointer

* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
* Source/WebCore/dom/ElementRareData.h:
(WebCore::ElementRareData::useTypes const):
* Source/WebCore/dom/Node.cpp:
(WebCore::stringForRareDataUseType):
(WebCore::Node::dumpStatistics):
(WebCore::Node::Node):
* Source/WebCore/dom/NodeRareData.h:
(WebCore::NodeRareData::useTypes const):

Canonical link: https://commits.webkit.org/259796@main




More information about the webkit-changes mailing list