[webkit-changes] [WebKit/WebKit] 18a076: Importing an exported v128 global should be possible

Justin Michaud noreply at github.com
Thu Feb 2 19:25:41 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 18a076e402b4852d319c7755b34095d1df6d7917
      https://github.com/WebKit/WebKit/commit/18a076e402b4852d319c7755b34095d1df6d7917
  Author: Justin Michaud <justin at justinmichaud.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    A JSTests/wasm/stress/simd-import-global-2.js
    M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
    M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp
    M Source/JavaScriptCore/wasm/WasmGlobal.h
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyArray.h
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.cpp
    M Source/JavaScriptCore/wasm/js/JSWebAssemblyHelpers.h
    M Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.cpp
    M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

  Log Message:
  -----------
  Importing an exported v128 global should be possible
https://bugs.webkit.org/show_bug.cgi?id=251551
rdar://104745582

Reviewed by Mark Lam.

We missed a case here, let's just fix it.

* JSTests/wasm/stress/simd-import-global-2.js: Added.
(from.string_appeared_here.import.as.assert.from.string_appeared_here.async test):
* Source/JavaScriptCore/wasm/WasmGlobal.h:
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeImports):

Canonical link: https://commits.webkit.org/259791@main




More information about the webkit-changes mailing list