[webkit-changes] [WebKit/WebKit] 10cc14: Don't use CG display lists for bitmap-image-only l...

Tim Horton noreply at github.com
Thu Feb 2 17:17:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 10cc1463e1dc31c50b8b4c888726277c2a9294a8
      https://github.com/WebKit/WebKit/commit/10cc1463e1dc31c50b8b4c888726277c2a9294a8
  Author: Tim Horton <thorton at apple.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/GraphicsLayerClient.h
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
    M Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerBacking.h
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp
    M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h

  Log Message:
  -----------
  Don't use CG display lists for bitmap-image-only layers
https://bugs.webkit.org/show_bug.cgi?id=251448
rdar://103615295

Reviewed by Simon Fraser.

* Source/WebCore/platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::layerContainsBitmapOnly const):
* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
* Source/WebCore/platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerContainsBitmapOnly const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isBitmapOnly const):
* Source/WebCore/rendering/RenderLayerBacking.h:
Plumb "isBitmapOnly", which is much like the existing "isUnscaledBitmapOnly",
but returns true even in cases where the bitmap is scaled, or the page has pageScale < 1.

* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::shouldIncludeDisplayListInBackingStore):
(WebKit::PlatformCALayerRemote::updateBackingStore):
* Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
Use isBitmapOnly to disable CG display lists, which are wasteful in this case.

Canonical link: https://commits.webkit.org/259788@main




More information about the webkit-changes mailing list