[webkit-changes] [WebKit/WebKit] b369d6: Add static assertions in generated serialization c...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b369d6af63fe770df55f19584fbd8dea19c43b40
      https://github.com/WebKit/WebKit/commit/b369d6af63fe770df55f19584fbd8dea19c43b40
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp
    M Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h
    M Source/WebCore/platform/graphics/Pattern.h
    M Source/WebKit/Scripts/generate-serializers.py
    M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp
    M Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in
    M Source/WebKit/Shared/API/APIError.serialization.in
    M Source/WebKit/Shared/API/APIFrameHandle.serialization.in
    M Source/WebKit/Shared/API/APIGeometry.serialization.in
    M Source/WebKit/Shared/API/APIPageHandle.serialization.in
    M Source/WebKit/Shared/API/APIURL.serialization.in
    M Source/WebKit/Shared/API/APIURLRequest.serialization.in
    M Source/WebKit/Shared/API/APIURLResponse.serialization.in
    M Source/WebKit/Shared/SessionState.serialization.in
    M Source/WebKit/Shared/ShareableBitmap.serialization.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/Shared/mac/SecItemResponseData.h

  Log Message:
  -----------
  Add static assertions in generated serialization code to verify correct member ordering
https://bugs.webkit.org/show_bug.cgi?id=251536
rdar://104925697

Reviewed by Ben Nham.

Also document all attributes and remove unneeded ones.

* Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.cpp:
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
* Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h:
* Source/WebCore/platform/graphics/Pattern.h:
* Source/WebKit/Scripts/generate-serializers.py:
(SerializedType.__init__):
(SerializedType.can_assert_member_order_is_correct):
(check_type_members):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(IPC::ArgumentCoder<Namespace::OtherClass>::encode):
(IPC::ArgumentCoder<Namespace::EmptyConstructorNullable>::encode):
(IPC::ArgumentCoder<NullableSoftLinkedMember>::encode):
* Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in:
* Source/WebKit/Shared/API/APIError.serialization.in:
* Source/WebKit/Shared/API/APIFrameHandle.serialization.in:
* Source/WebKit/Shared/API/APIGeometry.serialization.in:
* Source/WebKit/Shared/API/APIPageHandle.serialization.in:
* Source/WebKit/Shared/API/APIURL.serialization.in:
* Source/WebKit/Shared/API/APIURLRequest.serialization.in:
* Source/WebKit/Shared/API/APIURLResponse.serialization.in:
* Source/WebKit/Shared/SessionState.serialization.in:
* Source/WebKit/Shared/ShareableBitmap.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/Shared/mac/SecItemResponseData.h:
(WebKit::SecItemResponseData::SecItemResponseData):

Canonical link: https://commits.webkit.org/259784@main