[webkit-changes] [WebKit/WebKit] df642c: Change sensitivity level of webpushd diagnostic logs

bnham noreply at github.com
Thu Feb 2 11:30:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df642c8ddfa4362d7fbce0f853bad4a6d6fa6126
      https://github.com/WebKit/WebKit/commit/df642c8ddfa4362d7fbce0f853bad4a6d6fa6126
  Author: Ben Nham <nham at apple.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    M Source/WebKit/webpushd/PushService.mm

  Log Message:
  -----------
  Change sensitivity level of webpushd diagnostic logs
https://bugs.webkit.org/show_bug.cgi?id=251602
rdar://104946575

Reviewed by Brady Eidson.

Make scope and topic logging of Web Push subscriptions sensitive by default, which affects how they
are logged on internal builds. This has no effect on customer builds, since both private and
sensitive log strings are redacted on such builds.

* Source/WebKit/webpushd/PushService.mm:
(WebPushD::PushServiceRequestImpl::fulfill):
(WebPushD::PushServiceRequestImpl::reject):
(WebPushD::SubscribeRequest::startImpl):
(WebPushD::UnsubscribeRequest::startInternal):
(WebPushD::PushService::incrementSilentPushCount):
(WebPushD::PushService::removeRecordsForSubscriptionSetAndOrigin):
(WebPushD::PushService::removeRecordsImpl):
(WebPushD::PushService::didReceivePushMessage):

Canonical link: https://commits.webkit.org/259764@main




More information about the webkit-changes mailing list