[webkit-changes] [WebKit/WebKit] 0d4927: [WGSL] Factor out context logic from MangleNames pass

Tadeu Zagallo noreply at github.com
Thu Feb 2 02:49:26 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0d49272caea1d1837813cb67302e346ffe067936
      https://github.com/WebKit/WebKit/commit/0d49272caea1d1837813cb67302e346ffe067936
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-02 (Thu, 02 Feb 2023)

  Changed paths:
    A Source/WebGPU/WGSL/ContextProvider.h
    A Source/WebGPU/WGSL/ContextProviderInlines.h
    M Source/WebGPU/WGSL/MangleNames.cpp
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WGSL] Factor out context logic from MangleNames pass
https://bugs.webkit.org/show_bug.cgi?id=251523
<rdar://problem/104921139>

Reviewed by Myles C. Maxfield.

Move the context logic out of the MangleNames pass so it can be
reused in the type checking pass.

* Source/WebGPU/WGSL/ContextProvider.h: Added.
* Source/WebGPU/WGSL/ContextProviderInlines.h: Added.
(WGSL::ContextProvider<Value>::Context::Context):
(WGSL::ContextProvider<Value>::Context::lookup const):
(WGSL::ContextProvider<Value>::Context::add):
(WGSL::ContextProvider<Value>::ContextScope::ContextScope):
(WGSL::ContextProvider<Value>::ContextScope::~ContextScope):
(WGSL::ContextProvider<Value>::ContextProvider):
(WGSL::ContextProvider<Value>::introduceVariable const):
(WGSL::ContextProvider<Value>::readVariable const const):
* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::run):
(WGSL::NameManglerVisitor::introduceVariable):
(WGSL::NameManglerVisitor::readVariable const):
(WGSL::NameManglerVisitor::Context::Context): Deleted.
(WGSL::NameManglerVisitor::Context::lookup const): Deleted.
(WGSL::NameManglerVisitor::Context::add): Deleted.
(WGSL::NameManglerVisitor::ContextScope::ContextScope): Deleted.
(WGSL::NameManglerVisitor::ContextScope::~ContextScope): Deleted.
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/259748@main




More information about the webkit-changes mailing list