[webkit-changes] [WebKit/WebKit] 0f6093: [web-animations] ASSERT(node.isConnected()) reache...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0f60938da30b2360f6b007b8d5a7adc3a720616f
      https://github.com/WebKit/WebKit/commit/0f60938da30b2360f6b007b8d5a7adc3a720616f
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-animations/CSSAnimation-getKeyframes-crash.html
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] ASSERT(node.isConnected()) reached in Style::Scope::forNode() in css/css-animations/CSSAnimation-getKeyframes-crash.html
https://bugs.webkit.org/show_bug.cgi?id=251516

Reviewed by Antti Koivisto.

We should check that the effect's target is non-null and connected before calling Style::Scope::forOrdinal()
with that target as the first parameter. This caused a crash in a newly-imported WPT test.

* LayoutTests/imported/w3c/web-platform-tests/css/css-animations/CSSAnimation-getKeyframes-crash.html: Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):

Canonical link: https://commits.webkit.org/259735@main