[webkit-changes] [WebKit/WebKit] a82aaf: Optimize padding in CachedRawResource

Simon Fraser noreply at github.com
Wed Feb 1 18:02:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a82aafd43736c40bcab96777d5bfc0aa7e7f3775
      https://github.com/WebKit/WebKit/commit/a82aafd43736c40bcab96777d5bfc0aa7e7f3775
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp
    M Source/WebCore/loader/CrossOriginEmbedderPolicy.h
    M Source/WebCore/loader/FetchOptions.h
    M Source/WebCore/loader/ResourceLoaderOptions.h
    M Source/WebCore/loader/cache/CachedRawResource.cpp
    M Source/WebCore/loader/cache/CachedRawResource.h
    M Source/WebCore/loader/cache/CachedResource.h
    M Source/WebCore/platform/network/ResourceRequestBase.h
    M Source/WebCore/platform/network/ResourceResponseBase.cpp
    M Source/WebCore/platform/network/ResourceResponseBase.h
    M Source/WebCore/platform/network/cf/ResourceError.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Optimize padding in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=251481
rdar://104901267

Reviewed by Alex Christensen.

CachedRawResource was 1104 bytes big, with 171 bytes of padding. Fix by
reordering data members in classes stored by value in CachedRawResource.
End result is a size of 1056 bytes, with 132 bytes of padding, so there
is more that can be done.

* Source/WebCore/loader/CrossOriginEmbedderPolicy.cpp:
(WebCore::CrossOriginEmbedderPolicy::isolatedCopy const):
(WebCore::CrossOriginEmbedderPolicy::isolatedCopy):
(WebCore::CrossOriginEmbedderPolicy::decode):
* Source/WebCore/loader/CrossOriginEmbedderPolicy.h:
* Source/WebCore/loader/FetchOptions.h:
(WebCore::FetchOptions::isolatedCopy const):
(WebCore::FetchOptions::isolatedCopy):
(WebCore::FetchOptions::FetchOptions):
* Source/WebCore/loader/ResourceLoaderOptions.h:
* Source/WebCore/loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource):
* Source/WebCore/loader/cache/CachedRawResource.h:
* Source/WebCore/loader/cache/CachedResource.h:
* Source/WebCore/platform/network/ResourceRequestBase.h:
(WebCore::ResourceRequestBase::RequestData::RequestData):
* Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::m_type):
(WebCore::m_httpStatusCode): Deleted.
* Source/WebCore/platform/network/ResourceResponseBase.h:
* Source/WebCore/platform/network/cf/ResourceError.h:
(WebCore::ResourceError::ResourceError):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259731@main




More information about the webkit-changes mailing list