[webkit-changes] [WebKit/WebKit] ffba41: [JSC] ref.func in init-expr should be validated wi...

Yusuke Suzuki noreply at github.com
Wed Feb 1 14:06:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ffba415d759f53b160682e9db859d901d36867a9
      https://github.com/WebKit/WebKit/commit/ffba415d759f53b160682e9db859d901d36867a9
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    A JSTests/wasm/stress/init-expr-ref-null-function-index-space-for-validation.js
    A JSTests/wasm/stress/resources/init-expr-ref-null-function-index-space-for-validation.wasm
    M Source/JavaScriptCore/wasm/WasmSectionParser.cpp

  Log Message:
  -----------
  [JSC] ref.func in init-expr should be validated with function-index-space
https://bugs.webkit.org/show_bug.cgi?id=251542
rdar://104911237

Reviewed by Mark Lam.

Use functionIndexSpaceSize for validation for ref.func in init-expr, since ref.func takes functionIndexSpace.
Note that functionIndexSpaceSize is always larger than functionIndex's size. We were wrongly rejecting valid
ref.func via validation.

* JSTests/wasm/stress/init-expr-ref-null-function-index-space-for-validation.js: Added.
(shouldBe):
(async let):
* JSTests/wasm/stress/resources/init-expr-ref-null-function-index-space-for-validation.wasm: Added.
* Source/JavaScriptCore/wasm/WasmSectionParser.cpp:
(JSC::Wasm::SectionParser::parseInitExpr):

Canonical link: https://commits.webkit.org/259715@main




More information about the webkit-changes mailing list