[webkit-changes] [WebKit/WebKit] dd0930: Prefix the SVGAnimationElement range setting metho...
Said Abou-Hallawa
noreply at github.com
Wed Feb 1 11:39:43 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd0930cde59d3dd6f7bdf7db838e4d400cf98dff
https://github.com/WebKit/WebKit/commit/dd0930cde59d3dd6f7bdf7db838e4d400cf98dff
Author: Said Abou-Hallawa <said at apple.com>
Date: 2023-02-01 (Wed, 01 Feb 2023)
Changed paths:
M Source/WebCore/svg/SVGAnimateElementBase.cpp
M Source/WebCore/svg/SVGAnimateElementBase.h
M Source/WebCore/svg/SVGAnimateMotionElement.cpp
M Source/WebCore/svg/SVGAnimateMotionElement.h
M Source/WebCore/svg/SVGAnimationElement.cpp
M Source/WebCore/svg/SVGAnimationElement.h
Log Message:
-----------
Prefix the SVGAnimationElement range setting methods with "set" instead of "calculate"
https://bugs.webkit.org/show_bug.cgi?id=251450
rdar://104881126
Reviewed by Nikolas Zimmermann.
This will make the code more readable and the names of these methods will match
the names of the SVGAttributeAnimator methods which are called by these methods.
* Source/WebCore/svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::setFromAndToValues):
(WebCore::SVGAnimateElementBase::setFromAndByValues):
(WebCore::SVGAnimateElementBase::setToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateFromAndByValues): Deleted.
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue): Deleted.
* Source/WebCore/svg/SVGAnimateElementBase.h:
* Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::setFromAndToValues):
(WebCore::SVGAnimateMotionElement::setFromAndByValues):
(WebCore::SVGAnimateMotionElement::setToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues): Deleted.
* Source/WebCore/svg/SVGAnimateMotionElement.h:
* Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
(WebCore::SVGAnimationElement::updateAnimation):
* Source/WebCore/svg/SVGAnimationElement.h:
Canonical link: https://commits.webkit.org/259705@main
More information about the webkit-changes
mailing list