[webkit-changes] [WebKit/WebKit] 63e381: [JSC] Referenced function is functionIndexSpace

Yusuke Suzuki noreply at github.com
Wed Feb 1 11:07:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 63e3817996f2a420d1f880c520ab06ba245f5f5a
      https://github.com/WebKit/WebKit/commit/63e3817996f2a420d1f880c520ab06ba245f5f5a
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    A JSTests/wasm/stress/only-referenced.js
    A JSTests/wasm/stress/resources/only-referenced.wasm
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
    M Source/JavaScriptCore/wasm/WasmModuleInformation.h
    M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp

  Log Message:
  -----------
  [JSC] Referenced function is functionIndexSpace
https://bugs.webkit.org/show_bug.cgi?id=251522
rdar://104912723

Reviewed by Tadeu Zagallo.

Wasm Referenced functions are managed via functionIndexSpace, but we are querying to it via functionIndex, which is wrong.
This patch fixes it.

* JSTests/wasm/stress/only-referenced.js: Added.
(async let):
* JSTests/wasm/stress/resources/only-referenced.wasm: Added.
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::compileFunction):
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmModuleInformation.h:
(JSC::Wasm::ModuleInformation::hasReferencedFunction const):
(JSC::Wasm::ModuleInformation::addReferencedFunction const):
(JSC::Wasm::ModuleInformation::callCanClobberInstance const):
(JSC::Wasm::ModuleInformation::addClobberingTailCall):
* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeExports):

Canonical link: https://commits.webkit.org/259702@main




More information about the webkit-changes mailing list