[webkit-changes] [WebKit/WebKit] ec8c0f: [WGSL] Rename `ArgumentBuffer` roles to `BindGroup`

Tadeu Zagallo noreply at github.com
Wed Feb 1 01:58:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ec8c0fe9d7ca497f95f5ef3952ff3721ee768f7d
      https://github.com/WebKit/WebKit/commit/ec8c0fe9d7ca497f95f5ef3952ff3721ee768f7d
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M Source/WebGPU/WGSL/AST/ASTParameterValue.h
    M Source/WebGPU/WGSL/AST/ASTStructure.h
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Rename `ArgumentBuffer` roles to `BindGroup`
https://bugs.webkit.org/show_bug.cgi?id=251443
rdar://104873689

Reviewed by Myles C. Maxfield.

Let's try use the WGSL nomenclature instead of Metal in parts of the
codebase that aren't Metal-specific (whenever possible)

* Source/WebGPU/WGSL/AST/ASTFunctionDecl.h:
* Source/WebGPU/WGSL/AST/ASTStructureDecl.h:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::insertStructs):
(WGSL::RewriteGlobalVariables::insertParameters):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/259670@main




More information about the webkit-changes mailing list