[webkit-changes] [WebKit/WebKit] 4c52b0: Use Markable instead of std::optional when storing...

Alex Christensen noreply at github.com
Wed Feb 1 00:21:39 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c52b0658f9cb5c07e054f4ae1ffe7788da7be3e
      https://github.com/WebKit/WebKit/commit/4c52b0658f9cb5c07e054f4ae1ffe7788da7be3e
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-02-01 (Wed, 01 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/UUID.h
    M Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.h
    M Source/WebKit/NetworkProcess/NetworkSession.h
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
    M Source/WebKit/Platform/IPC/DaemonCoders.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h
    M Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in
    M Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h
    M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h
    M Source/WebKit/webpushd/PushClientConnection.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm

  Log Message:
  -----------
  Use Markable instead of std::optional when storing UUIDs in structs
https://bugs.webkit.org/show_bug.cgi?id=251485
rdar://104902597

Reviewed by Yusuke Suzuki.

This removes unnecessary and unused padding bytes, decreasing memory use.

* Source/WTF/wtf/UUID.h:
(WTF::UUID::MarkableTraits::isEmptyValue):
(WTF::UUID::MarkableTraits::emptyValue):
* Source/WebCore/Modules/push-api/PushSubscriptionIdentifier.h:
* Source/WebKit/NetworkProcess/NetworkSession.h:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.cpp:
(WebKit::NetworkSessionCreationParameters::decode):
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/Platform/IPC/DaemonCoders.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.h:
* Source/WebKit/Shared/WebPushDaemonConnectionConfiguration.serialization.in:
* Source/WebKit/UIProcess/Extensions/WebExtensionControllerConfiguration.h:
(WebKit::WebExtensionControllerConfiguration::identifier const):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
(WebKit::WebsiteDataStoreConfiguration::identifier const):
* Source/WebKit/webpushd/PushClientConnection.h:
(WebPushD::ClientConnection::dataStoreIdentifier const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:

Canonical link: https://commits.webkit.org/259665@main




More information about the webkit-changes mailing list