[webkit-changes] [WebKit/WebKit] 44fccb: Fix wide-attachment-image-controls-basic test

Gerald Squelart noreply at github.com
Sun Dec 31 22:29:01 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44fccba78690ca1160f1d8c8776103e8540a0bae
      https://github.com/WebKit/WebKit/commit/44fccba78690ca1160f1d8c8776103e8540a0bae
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2023-12-31 (Sun, 31 Dec 2023)

  Changed paths:
    M LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
    M LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic.html
    A LayoutTests/platform/mac-monterey/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt
    M LayoutTests/platform/mac-wk2/TestExpectations
    R LayoutTests/platform/mac/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt

  Log Message:
  -----------
  Fix wide-attachment-image-controls-basic test
https://bugs.webkit.org/show_bug.cgi?id=259528
rdar://112918166

Reviewed by Tim Nguyen.

Delay the rendering screenshot until the attachment icon has loaded.

* LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic.html:
* LayoutTests/platform/mac-wk2/TestExpectations:

* LayoutTests/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt:
* LayoutTests/platform/mac-monterey/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt: Renamed from LayoutTests/platform/mac/fast/attachment/mac/wide-attachment-image-controls-basic-expected.txt.
There is a slight difference between how Monterey and Sonoma blend
the attachment background, which is the tertiary-fill (0,0,0,5%).
5% of 255 is 12.75.
- On Monterey this is rounded up to 13 -> #0000000D
- On Sonoma this is truncated down to 12 -> #0000000C

Canonical link: https://commits.webkit.org/272548@main




More information about the webkit-changes mailing list