[webkit-changes] [WebKit/WebKit] 2afefe: Fix rounding of very large and very small LayoutUnits

Ahmad Saleem noreply at github.com
Fri Dec 29 21:43:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2afefe7449cd82d4b70c9ed85add5827f44e7278
      https://github.com/WebKit/WebKit/commit/2afefe7449cd82d4b70c9ed85add5827f44e7278
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-12-29 (Fri, 29 Dec 2023)

  Changed paths:
    M LayoutTests/platform/ios/fast/block/float/overhanging-tall-block-expected.txt
    M LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt
    M LayoutTests/platform/wpe/fast/block/float/overhanging-tall-block-expected.txt
    M Source/WebCore/platform/LayoutUnit.h
    M Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp

  Log Message:
  -----------
  Fix rounding of very large and very small LayoutUnits

https://bugs.webkit.org/show_bug.cgi?id=266869

Reviewed by Alan Baradlay.

Merge: https://source.chromium.org/chromium/chromium/src/+/a7b04f8fe15406cbf98995da00fc63f73e9fff61

Previously, LayoutUnit's between nearlyMax() and max() would round
down, even though their fractional parts are > 0.5.  Similarly,
LayoutUnit's between min() and nearlyMin() would round up (toward
zero), even though their fractional parts are < -0.5.

* Source/WebCore/platform/LayoutUnit.h:
(round):
* Tools/TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp:
(LayoutUnitRounding): Added new test case
* LayoutTests/platform/ios/fast/block/float/overhanging-tall-block-expected.txt: Rebaselined
* LayoutTests/platform/wpe/fast/block/float/overhanging-tall-block-expected.txt: Ditto
* LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt: Ditto

Canonical link: https://commits.webkit.org/272534@main




More information about the webkit-changes mailing list