[webkit-changes] [WebKit/WebKit] e0e972: [WebGPU] CTS test validation/buffer/mapping.html i...

mwyrzykowski noreply at github.com
Thu Dec 28 17:19:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e0e9721a944e9c552f34a0d4856377b7a1b43b49
      https://github.com/WebKit/WebKit/commit/e0e9721a944e9c552f34a0d4856377b7a1b43b49
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-28 (Thu, 28 Dec 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/buffer/mapping-expected.txt
    M Source/WebCore/Modules/WebGPU/GPUBuffer.cpp
    M Source/WebCore/Modules/WebGPU/GPUBuffer.h
    M Source/WebGPU/WebGPU/Buffer.h
    M Source/WebGPU/WebGPU/Buffer.mm
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp

  Log Message:
  -----------
  [WebGPU] CTS test validation/buffer/mapping.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266497
<radar://119731119>

Reviewed by Tadeu Zagallo.

Add correct validation for Buffer mapping.

With this change, all GPUBuffer CTS tests are passing.

* LayoutTests/http/tests/webgpu/webgpu/api/validation/buffer/mapping-expected.txt:
* Source/WebCore/Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::mapAsync):
(WebCore::containsRange):
(WebCore::GPUBuffer::getMappedRange):
(WebCore::GPUBuffer::internalUnmap):
(WebCore::GPUBuffer::destroy):
* Source/WebCore/Modules/WebGPU/GPUBuffer.h:
* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::Buffer::errorValidatingMapAsync const):
(WebGPU::Buffer::mapAsync):
(WebGPU::Buffer::validateUnmap const):
(WebGPU::Buffer::unmap):
(WebGPU::Buffer::validateMapAsync const): Deleted.
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:
(WebKit::RemoteBuffer::mapAsync):
(WebKit::RemoteBuffer::unmap):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteBufferProxy.cpp:
(WebKit::WebGPU::RemoteBufferProxy::unmap):

Canonical link: https://commits.webkit.org/272526@main




More information about the webkit-changes mailing list