[webkit-changes] [WebKit/WebKit] 55fa63: [WebGPU] CTS test validation/buffer/create.html is...

mwyrzykowski noreply at github.com
Thu Dec 28 14:48:02 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 55fa6352bcf618f6e475b42483e786ffeae4da20
      https://github.com/WebKit/WebKit/commit/55fa6352bcf618f6e475b42483e786ffeae4da20
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-28 (Thu, 28 Dec 2023)

  Changed paths:
    M LayoutTests/http/tests/webgpu/webgpu/api/validation/buffer/create-expected.txt
    M Source/WebCore/Modules/WebGPU/GPUBufferUsage.h
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferUsage.h
    M Source/WebGPU/WebGPU/Buffer.mm

  Log Message:
  -----------
  [WebGPU] CTS test validation/buffer/create.html is failing
https://bugs.webkit.org/show_bug.cgi?id=266462
<radar://119708170>

Reviewed by Tadeu Zagallo.

Passing invalid flags should result in a device error so instead of using an
option set which may remove invalid flags, pass the direct value the from the JS
layer and perform validation in WebGPU.framework

* LayoutTests/http/tests/webgpu/webgpu/api/validation/buffer/create-expected.txt:
Add passing expectations.

* Source/WebCore/Modules/WebGPU/GPUBufferUsage.h:
(WebCore::compare):
(WebCore::convertBufferUsageFlagsToBacking):

* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::createBuffer):
Range error should only be thrown when mappedAtCreation == true

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUConvertToBackingContext.cpp:
(WebCore::WebGPU::compare):
(WebCore::WebGPU::ConvertToBackingContext::convertBufferUsageFlagsToBacking):
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.serialization.in:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferUsage.h:

* Source/WebGPU/WebGPU/Buffer.mm:
(WebGPU::validateCreateBuffer):
Make sure flags are within range.

Canonical link: https://commits.webkit.org/272524@main




More information about the webkit-changes mailing list