[webkit-changes] [WebKit/WebKit] ca3820: [WebGPU] bind group dynamic offsets are not implem...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca382024b6d3ecf1dc7042ed2d260d58fd1aa5c1
      https://github.com/WebKit/WebKit/commit/ca382024b6d3ecf1dc7042ed2d260d58fd1aa5c1
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-28 (Thu, 28 Dec 2023)

  Changed paths:
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/PipelineLayout.mm

  Log Message:
  -----------
  [WebGPU] bind group dynamic offsets are not implemented correctly, they don't correspond to the proper stage
https://bugs.webkit.org/show_bug.cgi?id=266815>
<radar://120049732>

Reviewed by Tadeu Zagallo.

Dynamic offsets assumed buffers had linearly increasing bind
group indices, which does not necessarily hold and is not
the case in Unity's demos.

Break this assumption by computing the corresponding index
from the source dynamic offsets buffer during bind group
layout generation time.

Then use this precomputed index instead of a linearly increasing
value in the PipelineLayout.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::Device::createBindGroupLayout):
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::PipelineLayout::offsetVectorForBindGroup):

Canonical link: https://commits.webkit.org/272522@main