[webkit-changes] [WebKit/WebKit] 3dee8c: [css-transitions] `transition` property should use...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3dee8c9a649aa8cc7d686907b21a6afc6f3132de
      https://github.com/WebKit/WebKit/commit/3dee8c9a649aa8cc7d686907b21a6afc6f3132de
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-12-27 (Wed, 27 Dec 2023)

  Changed paths:
    M LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt
    M LayoutTests/fast/css/shorthand-mismatched-list-crash.html
    M LayoutTests/fast/css/transform-inline-style-expected.txt
    M LayoutTests/fast/css/transform-inline-style-remove-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-behavior.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed.html
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/platform/animation/Animation.cpp
    M Source/WebCore/platform/animation/Animation.h

  Log Message:
  -----------
  [css-transitions] `transition` property should use shortest serialization rule
https://bugs.webkit.org/show_bug.cgi?id=266234

Reviewed by Tim Nguyen.

As discussed in https://github.com/web-platform-tests/wpt/issues/43574, serializing
the `transition` shorthand should always strive to produce the shortest serialization
and omit initial values.

We update the relevant tests, including WPT, to match this expectation and add a new test
for the case where `transition-delay` is not the initial value while `transition-duration`
is since those two properties have the same `<time>` type and `transition-duration` serializes
first.

* LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt:
* LayoutTests/fast/css/shorthand-mismatched-list-crash.html:
* LayoutTests/fast/css/transform-inline-style-expected.txt:
* LayoutTests/fast/css/transform-inline-style-remove-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-behavior.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/transition-computed.html:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::addValueForAnimationPropertyToList):
(WebCore::animationShorthandValue):
(WebCore::singleTransitionValue):
(WebCore::transitionShorthandValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::serializeLayered const):
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::Animation::animationsMatch const):
* Source/WebCore/platform/animation/Animation.h:
(WebCore::Animation::TransitionProperty::operator== const):

Canonical link: https://commits.webkit.org/272513@main