[webkit-changes] [WebKit/WebKit] 9573b6: [IFC][Geometry] Turn final BoxGeometry into visual...

Alan Baradlay noreply at github.com
Wed Dec 27 10:18:33 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9573b657056dae3a6c891cd4b04c7743f9286269
      https://github.com/WebKit/WebKit/commit/9573b657056dae3a6c891cd4b04c7743f9286269
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-27 (Wed, 27 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
    M Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp
    M Source/WebCore/layout/layouttree/LayoutBoxGeometry.h

  Log Message:
  -----------
  [IFC][Geometry] Turn final BoxGeometry into visual in InlineDisplayContentBuilder
https://bugs.webkit.org/show_bug.cgi?id=266898

Reviewed by Antti Koivisto.

In addition to setting the visual top/left on the box geometry, let's covert all values to visual.

At this point this does not have any effect as we only transfer the top/left coords back to the associated renderer
but 1, this is good for consistency as currently the final BoxGeometry has visual top/left with logical width/height and decoration values and
2, eventually we are going to need the rest of the geometry values in visual coordinates.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.cpp:
(WebCore::Layout::BoxGeometry::toVisualGeometry):
* Source/WebCore/layout/layouttree/LayoutBoxGeometry.h:

Canonical link: https://commits.webkit.org/272511@main




More information about the webkit-changes mailing list