[webkit-changes] [WebKit/WebKit] b00649: Make `iframe` containing SVG behave as every other...

Ahmad Saleem noreply at github.com
Tue Dec 26 13:03:19 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0064989cb96a615ee3ee6a756865b5d95aa0cfc
      https://github.com/WebKit/WebKit/commit/b0064989cb96a615ee3ee6a756865b5d95aa0cfc
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-12-26 (Tue, 26 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage-expected.txt
    A LayoutTests/platform/glib/svg/in-html/by-reference-expected.txt
    M LayoutTests/platform/mac/svg/in-html/by-reference-expected.txt
    M LayoutTests/svg/in-html/by-reference-expected.txt
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp

  Log Message:
  -----------
  Make `iframe` containing SVG behave as every other `iframe`

https://bugs.webkit.org/show_bug.cgi?id=266702

Reviewed by Tim Nguyen.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Inspired by: https://src.chromium.org/viewvc/blink?view=revision&revision=172467

When an SVG is contained inside an `iframe`, its dimensions should not
be part of size calculations of the `iframe`. Neither should the SVG's
own width and height be ignored when sizing the `svg` inside the
`iframe`.

* Source/WebCore/rendering/RenderWidget.cpp:
(RenderWidget::embeddedContentBox): Extended check for 'embeddedObject'
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGRoot.cpp:
(LegacyRenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Aligned with LBSE
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-percentage-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-fixed-expected.txt: Rebaselined
* LayoutTests/imported/w3c/web-platform-tests/html/rendering/replaced-elements/svg-embedded-sizing/svg-in-iframe-auto-expected.txt: Rebaselined
* LayoutTests/platform/glib/svg/in-html/by-reference-expected.txt: Rebaselined
* LayoutTests/svg/in-html/by-reference-expected.txt: Ditto
* LayoutTests/platform/mac/svg/in-html/by-reference-expected.txt: Ditto

Canonical link: https://commits.webkit.org/272503@main




More information about the webkit-changes mailing list