[webkit-changes] [WebKit/WebKit] 2cb2f8: [IFC][Geometry] Transition out-of-flow box geometr...

Alan Baradlay noreply at github.com
Mon Dec 25 21:09:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cb2f84b68df8a519e252d535de43e7d19567883
      https://github.com/WebKit/WebKit/commit/2cb2f84b68df8a519e252d535de43e7d19567883
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-25 (Mon, 25 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Geometry] Transition out-of-flow box geometry to visual (inline only)
https://bugs.webkit.org/show_bug.cgi?id=266885

Reviewed by Antti Koivisto.

This is in preparation for moving all final BoxGeometry coords to visual.

1. Let's set visual geometry on out-of-flow boxes during display box creation (we already do this for most of the other types like inline-blocks.)
2. Convert them back to logical at render tree transition as render tree needs logical coords (this will eventually go away with getting rid of the render tree)
(Note that this patch only covers out-of-flow boxes with inline display type -before getting blockified)

* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalRectForOpaqueBox const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::flipLogicalPointToVisualForWritingModeWithinLine):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/272498@main




More information about the webkit-changes mailing list