[webkit-changes] [WebKit/WebKit] cc14ba: Turn PseudoElementType and PagePseudoClassType int...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc14ba9d68a9036c8ca24e1db6263324fc9182a1
      https://github.com/WebKit/WebKit/commit/cc14ba9d68a9036c8ca24e1db6263324fc9182a1
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-23 (Sat, 23 Dec 2023)

  Changed paths:
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/DerivedSources-input.xcfilelist
    M Source/WebCore/DerivedSources-output.xcfilelist
    M Source/WebCore/DerivedSources.make
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/css/CSSComputedStyleDeclaration.cpp
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
    A Source/WebCore/css/SelectorPseudoElementMap.in
    R Source/WebCore/css/SelectorPseudoElementTypeMap.in
    M Source/WebCore/css/SelectorPseudoTypeMap.h
    M Source/WebCore/css/makeSelectorPseudoElementsMap.py
    M Source/WebCore/css/parser/CSSParserSelector.cpp
    M Source/WebCore/css/parser/CSSParserSelector.h
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.h
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp
    M Source/WebCore/style/PageRuleCollector.cpp
    M Source/WebCore/style/RuleData.cpp
    M Source/WebCore/style/RuleFeature.cpp
    M Source/WebCore/style/RuleSet.cpp

  Log Message:
  -----------
  Turn PseudoElementType and PagePseudoClassType into enum classes
https://bugs.webkit.org/show_bug.cgi?id=266839

Reviewed by Tim Nguyen.

Also rename them and adjacent functionality to PseudoElement and
PagePseudoClass.

And remove the unused MarginBoxType as well.

* Source/WebCore/CMakeLists.txt:
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources-output.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::pseudoIdFromString):
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificity):
(WebCore::CSSSelector::specificityForPage const):
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElement):
(WebCore::CSSSelector::selectorText const):
(WebCore::CSSSelector::parsePseudoElementType): Deleted.
* Source/WebCore/css/CSSSelector.h:
(WebCore::CSSSelector::isWebKitCustomPseudoElement const):
(WebCore::CSSSelector::pseudoElement const):
(WebCore::CSSSelector::setPseudoElement):
(WebCore::CSSSelector::pagePseudoClass const):
(WebCore::CSSSelector::setPagePseudoClass):
(WebCore::CSSSelector::pseudoElementType const): Deleted.
(WebCore::CSSSelector::setPseudoElementType): Deleted.
(WebCore::CSSSelector::pagePseudoClassType const): Deleted.
(WebCore::CSSSelector::setPagePseudoType): Deleted.
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively const):
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in:
* Source/WebCore/css/SelectorPseudoElementMap.in: Renamed from Source/WebCore/css/SelectorPseudoElementTypeMap.in.
* Source/WebCore/css/SelectorPseudoTypeMap.h:
* Source/WebCore/css/makeSelectorPseudoElementsMap.py:
(enumerablePseudoType):
* Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePagePseudoSelector):
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoClassSelector):
* Source/WebCore/css/parser/CSSParserSelector.h:
(WebCore::CSSParserSelector::pseudoElement const):
(WebCore::CSSParserSelector::setPseudoElement):
(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
(WebCore::CSSParserSelector::isPseudoElementCueFunction const):
(WebCore::CSSParserSelector::pseudoElementType const): Deleted.
(WebCore::CSSParserSelector::setPseudoElementType): Deleted.
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::extractCompoundFlags):
(WebCore::isPseudoClassValidAfterPseudoElement):
(WebCore::isTreeAbidingPseudoElement):
(WebCore::isSimpleSelectorValidAfterPseudoElement):
(WebCore::CSSSelectorParser::consumeCompoundSelector):
(WebCore::isOnlyPseudoElementFunction):
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::splitCompoundAtImplicitShadowCrossingCombinator):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):
* Source/WebCore/css/parser/CSSSelectorParser.h:
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::getMatchedCSSRules const):
* Source/WebCore/style/PageRuleCollector.cpp:
(WebCore::Style::checkPageSelectorComponents):
* Source/WebCore/style/RuleData.cpp:
(WebCore::Style::determinePropertyAllowlist):
* Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::computeSubSelectorMatchElement):
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):

Canonical link: https://commits.webkit.org/272477@main