[webkit-changes] [WebKit/WebKit] a6cfb8: JSTests options need to be updated after 272208 at main.
Commit Queue
noreply at github.com
Sat Dec 23 07:54:01 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a6cfb812b779ddc109abb36193c8778dd54c8877
https://github.com/WebKit/WebKit/commit/a6cfb812b779ddc109abb36193c8778dd54c8877
Author: Mark Lam <mark.lam at apple.com>
Date: 2023-12-23 (Sat, 23 Dec 2023)
Changed paths:
M JSTests/stress/bad-osr-exit-checkpoint-state-assertion-during-js-lock-destruction.js
M JSTests/stress/dfg-scan-inlined-tail-caller-frames-liveness.js
M JSTests/stress/early-return-from-builtin2.js
M JSTests/stress/eval-liveness-should-not-come-from-parser.js
M JSTests/stress/for-of-bad-internal-field-hoist.js
M JSTests/stress/inlining-for-of-should-validate.js
M JSTests/stress/verify-can-gc-node-index.js
M Tools/Scripts/run-jsc-stress-tests
Log Message:
-----------
JSTests options need to be updated after 272208 at main.
https://bugs.webkit.org/show_bug.cgi?id=266837
rdar://120064300
Reviewed by Justin Michaud.
Because --validateOptions=true is not enabled, some tests were silently ignoring required
options after the options got renamed / changed.
This patch also adds --validateOptions=true as a base option for JSC stress tests. This will
ensure that such issues arising from options changing won't go unnoticed again.
* JSTests/stress/bad-osr-exit-checkpoint-state-assertion-during-js-lock-destruction.js:
* JSTests/stress/dfg-scan-inlined-tail-caller-frames-liveness.js:
* JSTests/stress/early-return-from-builtin2.js:
* JSTests/stress/eval-liveness-should-not-come-from-parser.js:
* JSTests/stress/for-of-bad-internal-field-hoist.js:
* JSTests/stress/inlining-for-of-should-validate.js:
* JSTests/stress/verify-can-gc-node-index.js:
* Tools/Scripts/run-jsc-stress-tests:
Canonical link: https://commits.webkit.org/272471@main
More information about the webkit-changes
mailing list