[webkit-changes] [WebKit/WebKit] 176e16: [fullscreen] Stop unnecessarily unsetting the ifra...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 176e163ba0ff9b47f4486079ecf2a78ace837bcc
      https://github.com/WebKit/WebKit/commit/176e163ba0ff9b47f4486079ecf2a78ace837bcc
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M Source/WebCore/dom/FullscreenManager.cpp

  Log Message:
  -----------
  [fullscreen] Stop unnecessarily unsetting the iframe fullscreen flag
https://bugs.webkit.org/show_bug.cgi?id=266820
rdar://120052751

Reviewed by Ryosuke Niwa.

Remove this code to match the spec closer: https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen

It was originally to address a review comment:
https://github.com/WebKit/WebKit/pull/5467#discussion_r1041296533

But this review comment no longer applies now that `Element::setFullscreenFlag` only sets a single flag.

* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::clearFullscreenFlags): rename variable to be more consistent with other iframe downcasts in the file.
(WebCore::FullscreenManager::willEnterFullscreen):

Canonical link: https://commits.webkit.org/272462@main