[webkit-changes] [WebKit/WebKit] 519d5e: IFrameFullscreenFlag doesn't need to be on Node

Ryosuke Niwa noreply at github.com
Fri Dec 22 11:58:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 519d5e9d71a1a8e89e96dd82797544323fdee474
      https://github.com/WebKit/WebKit/commit/519d5e9d71a1a8e89e96dd82797544323fdee474
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/Node.h
    M Source/WebCore/html/HTMLIFrameElement.h

  Log Message:
  -----------
  IFrameFullscreenFlag doesn't need to be on Node
https://bugs.webkit.org/show_bug.cgi?id=266812

Reviewed by Tim Nguyen and Alan Baradlay.

Move IFrameFullscreenFlag from Node to HTMLIFrameElement where this flag is only ever set true.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setFullscreenFlag):
(WebCore::Element::setIFrameFullscreenFlag): Deleted.
* Source/WebCore/dom/Element.h:
(WebCore::Element::hasFullscreenFlag const):
(WebCore::Element::hasIFrameFullscreenFlag const): Deleted.
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::documentsToUnfullscreen):
(WebCore::clearFullscreenFlags): Added.
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::finishExitFullscreen):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::exitRemovedFullscreenElement):
* Source/WebCore/dom/Node.h:
* Source/WebCore/html/HTMLIFrameElement.h:

Canonical link: https://commits.webkit.org/272459@main




More information about the webkit-changes mailing list