[webkit-changes] [WebKit/WebKit] e7e610: Fix process launch signposts

bnham noreply at github.com
Fri Dec 22 11:17:06 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7e610b7120d2fd688e1d0881d7460921273394e
      https://github.com/WebKit/WebKit/commit/e7e610b7120d2fd688e1d0881d7460921273394e
  Author: Ben Nham <nham at apple.com>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M Source/WebKit/Resources/Signposts/SystemTracePoints.plist
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp
    M Source/WebKit/UIProcess/Launcher/ProcessLauncher.h
    M Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm

  Log Message:
  -----------
  Fix process launch signposts
https://bugs.webkit.org/show_bug.cgi?id=266783
rdar://120010295

Reviewed by Simon Fraser.

The current process launch signposts don't handle overlapping process launches or process launches
that terminate early correctly. Fix this by nesting the signposts by their ProcessIdentifier, and by
emitting a ProcessLaunchEnd signpost in the case that the process terminated while being launched.

* Source/WebKit/Resources/Signposts/SystemTracePoints.plist:
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::ProcessLauncher):
(WebKit::ProcessLauncher::~ProcessLauncher):
(WebKit::ProcessLauncher::platformDestroy):
(WebKit::ProcessLauncher::didFinishLaunchingProcess):
* Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::platformDestroy):
(WebKit::ProcessLauncher::~ProcessLauncher): Deleted.

Canonical link: https://commits.webkit.org/272457@main




More information about the webkit-changes mailing list