[webkit-changes] [WebKit/WebKit] 6c5386: Correct mixed vertical orientation of Mongolian an...

Ahmad Saleem noreply at github.com
Fri Dec 22 10:28:38 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c53862898c9af2cdd913b4c094fc307948ea1a6
      https://github.com/WebKit/WebKit/commit/6c53862898c9af2cdd913b4c094fc307948ea1a6
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-12-22 (Fri, 22 Dec 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/platform/graphics/FontCascadeFonts.cpp

  Log Message:
  -----------
  Correct mixed vertical orientation of Mongolian and Phags-pa characters per UTR#50 and css-writing-modes

https://bugs.webkit.org/show_bug.cgi?id=240279
rdar://problem/93426525

Reviewed by Alan Baradlay.

This patch aligns WebKit with Blink / Chromium and Gecko / Firefox.

Merge: https://chromium.googlesource.com/chromium/blink/+/e3ba3532accd84e6a0253705595b97556ae7ca67

Characters for Mongolian and Phags-Pa scripts were changed to R (rotate)
from U (upright) in rev 13 of the Unicode UTR#50[1], the specification of
character orientations in vertical flow. CSS Writing Modes Level 3 refers
this specification to use in vertical flow[2].

[1] https://www.unicode.org/reports/tr50/
[2] https://drafts.csswg.org/css-writing-modes/#vertical-orientations

* Source/WebCore/platform/graphics/FontCascadeFonts.cpp:
(shouldIgnoreRotation):
* LayoutTests/TestExpectations: Remove 'failing' expectation
* LayoutTests/platform/ios/TestExpectations: Can't add 'pixel' tolerance so adding
'ImageOnlyFailure' expectation
* LayoutTests/platform/glib/TestExpectations: Changing 'Pass' to 'ImageOnlyFailure' expectation
due to shaping across color change element boundaries being still broken

Canonical link: https://commits.webkit.org/272454@main




More information about the webkit-changes mailing list