[webkit-changes] [WebKit/WebKit] e353e4: [UnifiedPDF] PDF in style embed renders in the wro...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e353e4fd2798c593c6f57501514bc3c717e93f2e
      https://github.com/WebKit/WebKit/commit/e353e4fd2798c593c6f57501514bc3c717e93f2e
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    A LayoutTests/compositing/plugins/pdf/pdf-in-styled-embed-expected.txt
    A LayoutTests/compositing/plugins/pdf/pdf-in-styled-embed.html
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] PDF in style embed renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=266750
rdar://119969233

Reviewed by Alan Baradlay.

The UnifiedPDFPlugin's root layer has to be positioned relative to the compositing
layer of the RenderEmbeddedObject, which can be inflated by borders, outlines, padding
and shadows.

RenderLayerBacking knows best how to compute the right offset, so let it position
the plugin's root layer.

* LayoutTests/compositing/plugins/pdf/pdf-in-styled-embed-expected.txt: Added.
* LayoutTests/compositing/plugins/pdf/pdf-in-styled-embed.html: Added.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterWidgetResize):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):

Canonical link: https://commits.webkit.org/272443@main