[webkit-changes] [WebKit/WebKit] ca9aa8: LegacyCustomProtocolManager is incorrectly using t...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca9aa80579f0a3eab81504e3e8fcb81d75be4ea9
      https://github.com/WebKit/WebKit/commit/ca9aa80579f0a3eab81504e3e8fcb81d75be4ea9
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm
    M Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp

  Log Message:
  -----------
  LegacyCustomProtocolManager is incorrectly using the NetworkProcess object off the main thread
https://bugs.webkit.org/show_bug.cgi?id=266787

Reviewed by Alex Christensen.

LegacyCustomProtocolManager is incorrectly using the NetworkProcess object off the
main thread. NetworkProcess is only safe to use on the main thread.

Found this the hardware when I tried adding a threading assertion in 272402 at main.

This patch fixes the bug and re-lands the threading assertion.

* Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
* Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:
(WebKit::LegacyCustomProtocolManager::protectedNetworkProcess const):

Canonical link: https://commits.webkit.org/272437@main