[webkit-changes] [WebKit/WebKit] d56482: Remove PseudoElementUnknown and PseudoClassType::U...

Anne van Kesteren noreply at github.com
Thu Dec 21 13:19:36 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d56482629f2d93c96d6bac4e038e15c8c9008a8e
      https://github.com/WebKit/WebKit/commit/d56482629f2d93c96d6bac4e038e15c8c9008a8e
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/css/CSSComputedStyleDeclaration.cpp
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
    M Source/WebCore/css/SelectorPseudoTypeMap.h
    M Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py
    M Source/WebCore/css/makeSelectorPseudoElementsMap.py
    M Source/WebCore/css/parser/CSSParserSelector.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  Remove PseudoElementUnknown and PseudoClassType::Unknown
https://bugs.webkit.org/show_bug.cgi?id=266767

Reviewed by Antti Koivisto.

By removing these enum values we can be much more certain about when we
have selector and when we don't.

* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::pseudoIdFromString):
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::CSSComputedStyleDeclaration):
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in:
* Source/WebCore/css/SelectorPseudoTypeMap.h:
* Source/WebCore/css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
* Source/WebCore/css/makeSelectorPseudoElementsMap.py:
* Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoClassSelector):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::isSimpleSelectorValidAfterPseudoElement):
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::getMatchedCSSRules const):

Canonical link: https://commits.webkit.org/272429@main




More information about the webkit-changes mailing list