[webkit-changes] [WebKit/WebKit] 72335e: Remove no-op code from SelectorQuery
Anne van Kesteren
noreply at github.com
Thu Dec 21 02:59:40 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 72335ee184004bbb0eb8a90504108bb5cc0bfb4b
https://github.com/WebKit/WebKit/commit/72335ee184004bbb0eb8a90504108bb5cc0bfb4b
Author: Anne van Kesteren <annevk at annevk.nl>
Date: 2023-12-21 (Thu, 21 Dec 2023)
Changed paths:
M Source/WebCore/css/CSSSelector.h
M Source/WebCore/css/CSSSelectorList.cpp
M Source/WebCore/css/CSSSelectorList.h
M Source/WebCore/dom/SelectorQuery.cpp
Log Message:
-----------
Remove no-op code from SelectorQuery
https://bugs.webkit.org/show_bug.cgi?id=266698
Reviewed by Antti Koivisto.
I discovered that no other code was using hasInvalidSelector() and
selectorsNeedNamespaceResolution() and they seemed somewhat suspect as
the selector parser ought to have taken care of them. And as far as I
can tell it has.
The removal of CSSSelector::isCustomPseudoElement() is a follow-up to
272337 at main and 272339 at main.
* Source/WebCore/css/CSSSelector.h:
(WebCore::CSSSelector::isUnknownPseudoElement const): Deleted.
(WebCore::CSSSelector::isCustomPseudoElement const): Deleted.
* Source/WebCore/css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): Deleted.
(WebCore::CSSSelectorList::selectorsNeedNamespaceResolution): Deleted.
(WebCore::SelectorHasInvalidSelectorFunctor::operator()): Deleted.
(WebCore::CSSSelectorList::hasInvalidSelector const): Deleted.
* Source/WebCore/css/CSSSelectorList.h:
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::SelectorQueryCache::add):
Canonical link: https://commits.webkit.org/272408@main
More information about the webkit-changes
mailing list