[webkit-changes] [WebKit/WebKit] 6a8d6e: [UnifiedPDF] Odd gray backgrounds for short PDFs o...

Simon Fraser noreply at github.com
Wed Dec 20 19:25:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a8d6ea573305298d429d9f26bf546196f2a04b6
      https://github.com/WebKit/WebKit/commit/6a8d6ea573305298d429d9f26bf546196f2a04b6
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Odd gray backgrounds for short PDFs or when rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=266746
rdar://119849112

Reviewed by Tim Horton.

Instead of painting the gray background into the scrolling tiles, put it on the root layer as a GraphicsLayer
background color. Also size the root layer to fill the plugin view.

This makes the PDF tiles transparent where not covered by pages. We may in future decide to make them opaque
and paint the color if necessary for performance.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::ensureLayers):
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
(WebKit::UnifiedPDFPlugin::paintContents):

Canonical link: https://commits.webkit.org/272398@main




More information about the webkit-changes mailing list