[webkit-changes] [WebKit/WebKit] 5cef00: [SVG] BreakingContext::handleEndOfLine should comm...

Alan Baradlay noreply at github.com
Wed Dec 20 18:47:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cef0021cfa099e9177f3533d685d154c19db90a
      https://github.com/WebKit/WebKit/commit/5cef0021cfa099e9177f3533d685d154c19db90a
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/line/BreakingContext.h

  Log Message:
  -----------
  [SVG] BreakingContext::handleEndOfLine should commit m_lastObject
https://bugs.webkit.org/show_bug.cgi?id=266745
<rdar://116427779>

Reviewed by Simon Fraser.

Normally in handleEndOfLine, we either have preserve/nowrap type of content with the the combination of a valid m_lastObject
and a null m_current.renderer (meaning end of content) or a valid m_current.renderer.
However due to some special SVG behavior (see isSVGText), we could end up here pointing to _after_ the last object (m_current.renderer() is null_ptr)
with seemingly breakable content.

* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleEndOfLine):

Canonical link: https://commits.webkit.org/272396@main




More information about the webkit-changes mailing list