[webkit-changes] [WebKit/WebKit] c21388: Deduplicate the correctionIndicatorType method.

Commit Queue noreply at github.com
Wed Dec 20 15:26:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c213889156180d79d3d01c5108e2152c2b318c40
      https://github.com/WebKit/WebKit/commit/c213889156180d79d3d01c5108e2152c2b318c40
  Author: nmahendru <nitinmahendru at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/page/ios/FrameIOS.mm
    A Source/WebCore/page/mac/CorrectionIndicator.h
    A Source/WebCore/page/mac/CorrectionIndicator.mm
    M Source/WebKit/UIProcess/mac/CorrectionPanel.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm

  Log Message:
  -----------
  Deduplicate the correctionIndicatorType method.
https://bugs.webkit.org/show_bug.cgi?id=248216
rdar://102760220

Reviewed by Alex Christensen.

Move the correctionIndicatorType into WebCore and use that
instead in WebKit/WebKitLegacy. Earlier, they both had the exact same function individually.

* Source/WebCore/page/mac/CorrectionIndicator.h: Added.
* Source/WebCore/page/mac/CorrectionIndicator.mm: Added.
(WebCore::correctionIndicatorType):

* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/mac/CorrectionIndicator.h:
* Source/WebCore/page/mac/CorrectionIndicator.mm:
(WebCore::correctionIndicatorType):
* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(correctionIndicatorType): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm:
(correctionIndicatorType): Deleted.
* Source/WebCore/page/ios/FrameIOS.mm:

Canonical link: https://commits.webkit.org/272388@main




More information about the webkit-changes mailing list