[webkit-changes] [WebKit/WebKit] c822a6: Add support for align-content on table cells.

fantasai noreply at github.com
Wed Dec 20 12:57:17 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c822a6a0fccc6b15d462d1aa76352ca3808e51c4
      https://github.com/WebKit/WebKit/commit/c822a6a0fccc6b15d462d1aa76352ca3808e51c4
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt
    R LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt
    R LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCell.h

  Log Message:
  -----------
  Add support for align-content on table cells.
https://bugs.webkit.org/show_bug.cgi?id=266453
rdar://119701629

Reviewed by Sammy Gill.

Updates vertical-align conditionals in table rendering
to first check align-content, and map behavior accordingly.

* LayoutTests/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt: Update to pass
* LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt: Removed.
* LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-align/blocks/align-content-table-cell-expected.txt: Removed.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock): Skip alignment if we're a table cell
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding): Map align-content values to corresponding vertical-align behavior.
(WebCore::RenderTableCell::styleDidChange): Handle align-content style changes same as vertical-align.
(WebCore::RenderTableCell::scrollbarsChanged): Handle align-content centering same as vertical-align.
* Source/WebCore/rendering/RenderTableCell.h:
(WebCore::RenderTableCell::isBaselineAligned const): Update to check align-content first.

Canonical link: https://commits.webkit.org/272373@main




More information about the webkit-changes mailing list