[webkit-changes] [WebKit/WebKit] 45f6e1: Remove more cruft from ThemeMac

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 45f6e1268ddc571baf89cf94b2acf413348d592e
      https://github.com/WebKit/WebKit/commit/45f6e1268ddc571baf89cf94b2acf413348d592e
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm
    M Source/WebCore/platform/mac/ThemeMac.h
    M Source/WebCore/platform/mac/ThemeMac.mm
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/rendering/RenderThemeMac.h
    M Source/WebCore/rendering/RenderThemeMac.mm
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm

  Log Message:
  -----------
  Remove more cruft from ThemeMac
https://bugs.webkit.org/show_bug.cgi?id=266582

Reviewed by Aditya Keerthi.

ensuredView() was dead code and as such all the view interface
definitions were not actually doing anything.

_useFormSemanticContext was doing something (despite the noise) and to
preserve its functionality we move it to RenderTheme. This should work
as RenderTheme::singleton() is NeverDestroyed.

* Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayer::drawLayerContents):
* Source/WebCore/platform/mac/ThemeMac.h:
* Source/WebCore/platform/mac/ThemeMac.mm:
(-[WebCoreThemeWindow hasKeyAppearance]): Deleted.
(-[WebCoreThemeWindow isKeyWindow]): Deleted.
(-[WebCoreThemeView init]): Deleted.
(-[WebCoreThemeView window]): Deleted.
(-[WebCoreThemeView isFlipped]): Deleted.
(-[WebCoreThemeView currentEditor]): Deleted.
(-[WebCoreThemeView _automaticFocusRingDisabled]): Deleted.
(-[WebCoreThemeView _focusRingVisibleRect]): Deleted.
(-[WebCoreThemeView _focusRingClipAncestor]): Deleted.
(-[WebCoreThemeView _viewRoot]): Deleted.
(-[WebCoreThemeView addSubview:]): Deleted.
(WebCore::ThemeMac::ensuredView): Deleted.
(WebCore::ThemeMac::useFormSemanticContext): Deleted.
(WebCore::ThemeMac::setUseFormSemanticContext): Deleted.
(WebCore::ThemeMac::setFocusRingClipRect): Deleted.
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::useFormSemanticContext const):
(WebCore::RenderTheme::setUseFormSemanticContext):
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::useFormSemanticContext const): Deleted.
(WebCore::RenderThemeMac::documentViewFor const): Deleted.
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setUseFormSemanticContext):

Canonical link: https://commits.webkit.org/272368@main