[webkit-changes] [WebKit/WebKit] 46e0db: [IFC] Empty inline item range (no inline content) ...

Alan Baradlay noreply at github.com
Wed Dec 20 10:59:18 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 46e0dbab2a78dbde3c52666ca0e89c1adf73ccc4
      https://github.com/WebKit/WebKit/commit/46e0dbab2a78dbde3c52666ca0e89c1adf73ccc4
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    A LayoutTests/fast/text/empty-shrink-to-fit-content-crash-expected.txt
    A LayoutTests/fast/text/empty-shrink-to-fit-content-crash.html
    M Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp
    M Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp

  Log Message:
  -----------
  [IFC] Empty inline item range (no inline content) should not trigger line building
https://bugs.webkit.org/show_bug.cgi?id=263776
<rdar://117540112>

Reviewed by Antti Koivisto.

* LayoutTests/fast/text/empty-shrink-to-fit-content-crash-expected.txt: Added.
* LayoutTests/fast/text/empty-shrink-to-fit-content-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/IntrinsicWidthHandler.cpp:
(WebCore::Layout::IntrinsicWidthHandler::computedIntrinsicWidthForConstraint): do not run line building on empty inline content.
* Source/WebCore/layout/formattingContexts/inline/TextOnlySimpleLineBuilder.cpp: empty content should not be considered as text only.
(WebCore::Layout::TextOnlySimpleLineBuilder::isEligibleForSimplifiedTextOnlyInlineLayout):

Originally-landed-as: 267815.445 at safari-7617-branch (0a8a8cb63d95). rdar://119595875
Canonical link: https://commits.webkit.org/272359@main




More information about the webkit-changes mailing list