[webkit-changes] [WebKit/WebKit] 6bf65b: Stop using CheckedPtr / CheckedRef with GlyphDispl...

Chris Dumez noreply at github.com
Wed Dec 20 10:52:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6bf65b8c76753790142396a98a5466176534e546
      https://github.com/WebKit/WebKit/commit/6bf65b8c76753790142396a98a5466176534e546
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/GlyphDisplayListCache.cpp
    M Source/WebCore/rendering/GlyphDisplayListCache.h

  Log Message:
  -----------
  Stop using CheckedPtr / CheckedRef with GlyphDisplayListCacheEntry
https://bugs.webkit.org/show_bug.cgi?id=266705

Reviewed by Brent Fulgham.

Stop using CheckedPtr / CheckedRef with GlyphDisplayListCacheEntry. Use
WeakPtr / WeakRef instead to generate more actionable crashes.

This tested as performance neutral on Speedometer.

* Source/WebCore/rendering/GlyphDisplayListCache.cpp:
(WebCore::GlyphDisplayListCacheKeyTranslator::equal):
(WebCore::GlyphDisplayListCache::get):
* Source/WebCore/rendering/GlyphDisplayListCache.h:
(WebCore::GlyphDisplayListCacheEntryHash::hash):
(WebCore::GlyphDisplayListCacheEntryHash::equal):

Canonical link: https://commits.webkit.org/272357@main




More information about the webkit-changes mailing list