[webkit-changes] [WebKit/WebKit] ca41cc: [IFC] Demote partial invalidation to full damage w...

Alan Baradlay noreply at github.com
Wed Dec 20 08:14:14 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ca41cc3271e4306589b9bc21822a5ce0f1404d8b
      https://github.com/WebKit/WebKit/commit/ca41cc3271e4306589b9bc21822a5ce0f1404d8b
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/text/zero-height-first-line-assert-expected.txt
    A LayoutTests/fast/text/zero-height-first-line-assert.html
    M Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp

  Log Message:
  -----------
  [IFC] Demote partial invalidation to full damage when computed damage extent is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=263222
<rdar://117017324>

Reviewed by Antti Koivisto.

Fall back to full layout when we computed inconsistent damage extent.
(It could happen when previous layouts produced corrupt line content e.g. line with no boxes other than the root inline box).

* LayoutTests/fast/text/zero-height-first-line-assert-expected.txt: Added.
* LayoutTests/fast/text/zero-height-first-line-assert.html: Added.
* Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::leadingContentDisplayForLineIndex):
(WebCore::Layout::InlineInvalidation::updateInlineDamage):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentBuilder.cpp:
(WebCore::LayoutIntegration::InlineContentBuilder::build const):

Originally-landed-as: 267815.333 at safari-7617-branch (c1a2b21f2532). rdar://119594845
Canonical link: https://commits.webkit.org/272347@main




More information about the webkit-changes mailing list