[webkit-changes] [WebKit/WebKit] a23b77: querySelector() throws exception for -webkit-prefi...
Anne van Kesteren
noreply at github.com
Wed Dec 20 04:12:40 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a23b77e8bca1e6a510f6b23e688695ac68ccdb98
https://github.com/WebKit/WebKit/commit/a23b77e8bca1e6a510f6b23e688695ac68ccdb98
Author: Anne van Kesteren <annevk at annevk.nl>
Date: 2023-12-20 (Wed, 20 Dec 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/tree-abiding-pseudo-elements-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/selectors/parsing/parse-part-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/selectors/webkit-pseudo-element-expected.txt
M Source/WebCore/css/CSSSelectorList.cpp
M Source/WebCore/css/parser/CSSParserSelector.h
M Source/WebCore/css/parser/CSSSelectorParser.cpp
M Source/WebCore/css/parser/CSSSelectorParser.h
M Source/WebCore/dom/SelectorQuery.cpp
Log Message:
-----------
querySelector() throws exception for -webkit-prefixed pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=149160
rdar://99299129
Reviewed by Antti Koivisto.
SelectorHasInvalidSelectorFunctor which is only used by querySelector()
and friends treated custom pseudo-elements as invalid. This is wrong.
querySelector("::placeholder") and querySelector("::-webkit-asdf") are
perfectly acceptable inputs, they are just supposed to return null.
Also do some minor code cleanup while in the general area.
Canonical link: https://commits.webkit.org/272337@main
More information about the webkit-changes
mailing list